provider/AWS: Add new resource for creating objects in an S3 bucket

[m-s-austin]

This code adds a new resource that allows you to "preload" a bucket with objects. Usage is as follows:

here is a working example of the format.

resource "aws_s3_bucket" "b" {
    bucket = "ijoin_fork_terraform_distro"
    acl = "private"
    tags {
        Name = "My bucket"
        Environment = "Dev"
    }
    force_destroy = true
}

resource "aws_s3_bucket_object" "darwin" {
    depends_on = "aws_s3_bucket.b"       # Optional??
    bucket = "ijoin_fork_terraform_distro"
    key = "darwin_amd64.zip"
    source = "./darwin_amd64.1.zip"
}


resource "aws_s3_bucket_object" "linux" {
    depends_on = "aws_s3_bucket.b"
    bucket = "ijoin_fork_terraform_distro"
    key = "linux_amd64.zip"
    source = "./linux_amd64.1.zip"
}

Acceptance test is also working now :)

[catsby]

depends_on = "aws_s3_bucket.b"       # Optional??
bucket = "ijoin_fork_terraform_distro"

You can likely remove the depends_on if you reference ijoin_fork_terraform_distro directly:

resource "aws_s3_bucket_object" "darwin" {
  bucket = "${aws_s3_bucket.b.id}"
  key = "darwin_amd64.zip"
  source = "./darwin_amd64.1.zip"
}

[m-s-austin]

That makes sense! I have no idea why I didn’t think of that before. I will try that when I have some time to test it.

[catsby]

Hey @m-s-austin is this something you're still working on? Following up to see if you are, or need someone to try and take up the reins. Thanks!

[tyro89]

@catsby @m-s-austin I'm very interested in having this feature. Let me know if you need any help in getting it ready.

[m-s-austin]

@catsby sorry I have been slammed. we are just using it in our fork as it is. It's been working great!

[m-s-austin]

and also to verify

resource "aws_s3_bucket_object" "darwin" {
  bucket = "${aws_s3_bucket.b.id}"
  key = "darwin_amd64.zip"
  source = "./darwin_amd64.1.zip"
}

that format does work and removes needing the depends_on

[phinze]

I see code, acceptance test, and docs - looks like maybe this is good to go?

What do you think, @catsby?

[catsby]

I'm hesitant on using the ETag here, simply because the API mentions that if a user supplies their own key to encrypt the file(s), the ETag will not be the md5... it doesn't clearly say what it will be in that case though. I worry that down the road we expand on this and then get into a situation where we're losing objects :/

Can we simply use key here, instead?

[catsby]

Thanks again for the contribution. I had some more questions, but otherwise this works out.

It does need to be rebased on master and some changes made, notably

• aws instead of awslabs
• awsutil.StringValue is now longer around; aws structs now implement Stringer(), so you can just use log.Printf("[DEBUG] Result %s", resp) or similar
• The test still has the depends_on which isn't necessary if you do the interpolation like I mentioned above (nitpick)

[catsby]

All those things said, this is probably good enough, so that if you don't get to these things in the next day or so I'll just push my own branch based on this and do them myself. Thanks!

[catsby]

Closing in favor of #2898, thanks for the contribution @m-s-austin !

[pawan19]

I found the examples to upload objects by making ZIP but can we upload multiple files to S3 without Zip? If yes can you give me some example??
Here is my code:

resource "aws_s3_bucket" "testbucket" {
bucket = "test-terraform-1"
acl = "private"

tags = {
    Name  = "test-terraform"
    Environment = "test"
}

}

resource "aws_s3_bucket_object" "uploadfile" {
bucket = "test-terraform-1"
key = "index.html"
source = "/home/pawan/Documents/Projects/"

}

my files are inside project folders.

Thanks.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.