Adding "remote-exec" provisioner #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +66,10 @@ func resource_aws_instance_create( | |||
|
|
|||
| instance = instanceRaw.(*ec2.Instance) | |||
|
|
|||
| // Initialize the connection info | |||
| rs.ConnInfo.Raw["type"] = "ssh" | |||
There was a problem hiding this comment.
Why does ConnInfo struct still have a Type field. I feel like it would be nicer from a provider standpoint to just make ConnInfo a map[string]string maybe?
There was a problem hiding this comment.
Also: that is probably outside the scope of this PR, but just want feedback on that.
There was a problem hiding this comment.
Yeah I thought about it too. We could. Before there was some other fields. Its also map[string]interface{} for things like ports which can be numeric.
|
@mitchellh Can you re-review when you get a chance? |
|
LGTM. I'm going to bring this in now, and we'll continue to refine it. Let's talk about further TODOs on this tomorrow. |
mitchellh
added a commit
that referenced
this pull request
Jul 16, 2014
Adding "remote-exec" provisioner
pmoust
added a commit
to pmoust/terraform
that referenced
this pull request
Apr 20, 2015
…unch-configuration-resolve-conflicts Block device mapping launch configuration resolve conflicts
sarguru
pushed a commit
to sarguru/terraform
that referenced
this pull request
May 18, 2016
Add tests for nsone.datafeed resource
josephholsten
added a commit
to josephholsten/terraform
that referenced
this pull request
Jun 9, 2016
ultradns: cleanup
stack72
pushed a commit
that referenced
this pull request
May 11, 2017
…ion (#14341) * initial commit - 101-vm-from-user-image * changed branch name * not deploying - storage problems * provisions vm but image not properly prepared * storage not correct * provisions properly * changed main.tf to azuredeploy.tf * added tfvars and info for README * tfvars ignored and corrected file ext * added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing * deploy.sh to be executable * executable deploy files * added CI files; changed vars * prep for PR * removal of old folder * prep for PR * wrong args for travis * more PR prep * updated README * commented out variables in terraform.tfvars * Topic 101 vm from user image (#2) * initial commit - 101-vm-from-user-image * added tfvars and info for README * added CI config; added sane defaults for variables; updated deployment script, added mac specific deployment for local testing * prep for PR * added new template * oops, left off master * prep for PR * correct repository for destination * renamed scripts to be more intuitive; added check for docker * merge vm simple; vm from image * initial commit * deploys locally * updated deploy * consolidated deploy and after_deploy into a single script; simplified ci process; added os_profile_linux_config * added terraform show * initial commit * changed to allow http & https (like ARM tmplt) * changed host_name & host_name variable desc * added az cli check * on this branch, only build test_dir; master will aggregate all the examples * deploys locally; need to fix deploy scripts * chmod for deploy.ci.sh * corrected deploy.ci.sh * added resource group var to travis.yml * merge master * edited travis.yml * fixed error on travis.yml * added new constructs/naming for deploy scripts, etc. * took rg variable out; added destroy resources to travis.yml * cleaned up commented out lines in deploy.ci.sh * suppress az login output * suppress az login output * forgot about line breaks * breaking build as an example * fixing broken build example * merge of CI config * prep for PR * cleanup for PR * fixed grammar in readme * prep for PR * took out armviz button and minor README changes * changed host_name * fixed merge conflicts * changed host_name variable * updating Hashicorp's changes to merged simple linux branch * updating files to merge w/master and prep for Hashicorp pr * Revert "updating files to merge w/master and prep for Hashicorp pr" This reverts commit b850cd5. * Revert "updating Hashicorp's changes to merged simple linux branch" This reverts commit dbaf8d1. * removing vm from user image example from this branch * removed old branch * added depends_on resource group for workaround to bug * resolving conflicts * restoring previous examples/resolving merge conflict * resolving conflict * updated .travis.yml * azure-2-vms-loadbalancer-lbrules (#13) * initial commit * need to change lb_rule & nic * deploys locally * updated README * updated travis and deploy scripts for Hari's repo * renamed deploy script * clean up * prep for PR * updated readme * fixing conflict in .travis.yml * add CI build tag * updated descriptions * azure-traffic-manager-vm (#17) adding example of azure traffic manager * azure-vnet-to-vnet-peering (#20) adding vnet-to-vnet-peering example * returning .travis.yml to correct state * azure-search-create (#21) adding azure-search-create example * merging Hashicorp master into this branch * added graph to README * removing unmerged examples
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding remote-exec provisioner which can execute a script, scripts, or an inline set of commands on the remote host.