provider/openstack: minor fixes #2138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the openstack compute instance security_group schema from a list to set. This eliminates ordering problems and brings it in line with the aws instance's security_group schema. Change openstack router admin_state_up schema from a string to a bool, similar to Mitchell's changes to fix #1741 Includes dupuy's changes which fixed a crash caused by these changes.
Only the azure_instance is fully working (for both Linux and Windows instances) now, but needs some tests. network and disk and pretty much empty, but the idea is clear so will not take too much time…
Starting to look pretty nice…
Next to the remaining docs, I also updated the code so any Virtual Network related API calls are now synchronised by using a mutex (thanks @aznashwan for pointing that out!).
This example is derived from @phinze's [work seen here](#1893 (comment))
This is a simple one.. Docs were missing a closing }
Switching the healthcheck from elb->ec2 or ec2->elb shouldn't cause the ASG to re-create itself
Adds update method for ElastiCache Subnet Groups, things are not all ForceNew anymore. - can update description - can update subnet ids
If a tilde is used in the path, this makes sure we expand it to a full path.
they work on maps with both keys and values that are string types, which AFAICT are the only types of maps we have right now. closes #1915
Both to_ and from_ port must be zero to use protocol -1.
|
Oh crap, something happened and I think you need to rebase. Can you rebase this PR and reopen it please? Sorry! (We didn't force push so I"m not sure what happened on our end) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repeat of PR 1848, #1848, cleaned up a bit, with dupuy's fixes included.
Change the OpenStack providers compute resource security_groups schema from a list to a set.
When the security groups are a list, terraform will often indicate change due to a simple reordering of the security group. By changing this to a set, it not only matches the aws providers compute resource, it avoids ordering problems.
Change the OpenStack provider's router resource admin_state_up attribute from a string to a bool
In the openstack provider's router resource, the admin_state_up value's schema type is string. This changes it to a boolean, similar Mitchell's changes to fix #1741