core: Fix handling of individual map keys in ignore_changes #21788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix to make sure that an expression with a static string index, like foo["bar"], will be parsed as a traversal rather than as a dynamic index expression.
This also includes a previously-missing test that verifies the behavior described here, implemented as a planning context test for consistency with how the other ignore_changes tests are handled.
jbardin
approved these changes
Jun 18, 2019
|
@apparentlymart This PR does not fix the issue #21433 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Terraform 0.12 we had intended to start supporting ignoring individual map keys such as individual tags in a tags map. Unfortunately some later changes to HCL's parser inadvertently broke that behavior, so at release referring to a map key in
ignore_changeswould lead to an error:The main fix here was in HCL itself, so this PR begins with a vendor update to include that fix, but then also includes a documentation update to explain how this works and the addition/removal caveat that applies to it, along with a test for this specific behavior to reduce the risk of this inadvertently regressing again in the future.
This closes #6632 and closes #21433.