Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two serious problems when using links in Docker containers #2327

Merged
merged 3 commits into from
Jun 29, 2015
Merged

Fix two serious problems when using links in Docker containers #2327

merged 3 commits into from
Jun 29, 2015

Commits on Jun 25, 2015

  1. When linking to other containers, introduce a slight delay; this lets 

    the Docker API get those containers running. Otherwise when
you try to start a container linking to them, the start command
will fail, leading to an error.
    @jefferai
    jefferai committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    2e01e06 View commit details
    Browse the repository at this point in the history

  2. Fix a serious problem when using links. 

    Links cause there to be more than one name for a container to be
returned. As a result, only looking at the first element of the
container names could cause a container to not be found, leading
Terraform to remove it from state and attempt to recreate it.
    @jefferai
    jefferai committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    56cfba2 View commit details
    Browse the repository at this point in the history

  3. As discussed on the issue, remove the hard-coded delay on startup in 

    favor of attempting to detect if the initial container ever enters
running state, and erroring out if not. It will re-check the container
once every 500ms for 15 seconds total; future work could make that
configurable.
    @jefferai
    jefferai committed Jun 25, 2015
    Configuration menu
    Copy the full SHA
    edbc578 View commit details
    Browse the repository at this point in the history