Add ForceNew metadata_startup_script field #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkprime
force-pushed
the
startup-script
branch
from
00ee022
to
ac979d0
Compare
|
In AWS Am I understanding the scenario properly? If so, SGTM! |
|
This LGTM to me as well, merge at will @sparkprime |
sparkprime
force-pushed
the
startup-script
branch
from
52f94d5
to
447da21
Compare
sparkprime
added a commit
that referenced
this pull request
Jul 2, 2015
Add ForceNew metadata_startup_script field
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lacks tests & docs, but I wanted to discuss it before working further:
The idea is that if you use the metadata field startup-script to define the internal state of the instance, then you want changing that script to recreate the instance. The same is true for aws_instance and the userdata field, but this PR is just for GCE right now.
This solution adds another attribute called metadata_startup_script that is ForceNew and cannot be specified at the same time as metadata.startup_script.
What do you think?