-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preemptible and automatic_restart options on GCE instance #2383
Conversation
@@ -246,6 +246,20 @@ func resourceComputeInstance() *schema.Resource { | |||
Type: schema.TypeString, | |||
Computed: true, | |||
}, | |||
|
|||
"automatic_restart": &schema.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be in a nested structure called "scheduling" so we don't drift too far away from the official schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May as well also add the third one "on_host_maintenance"
They don't have to be ForceNew either, but it's fine to make them ForceNew in a first pass and then add update ability later.
This is useful, thanks |
@haklop it would be nice to get this in, do you plan to apply suggested changes? 😉 |
Thanks for the headstart, @haklop! I'm closing this as the feature is now in. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Add preemptible (https://cloud.google.com/compute/docs/instances/preemptible) and automatic_restart (https://cloud.google.com/compute/docs/instances/#autorestart) options on GCE instance