Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preemptible and automatic_restart options on GCE instance #2383

Closed
wants to merge 2 commits into from

Conversation

haklop
Copy link
Contributor

@haklop haklop commented Jun 17, 2015

@@ -246,6 +246,20 @@ func resourceComputeInstance() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},

"automatic_restart": &schema.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in a nested structure called "scheduling" so we don't drift too far away from the official schema.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well also add the third one "on_host_maintenance"

They don't have to be ForceNew either, but it's fine to make them ForceNew in a first pass and then add update ability later.

@sparkprime
Copy link
Contributor

This is useful, thanks

@radeksimko
Copy link
Member

@haklop it would be nice to get this in, do you plan to apply suggested changes? 😉

@sparkprime
Copy link
Contributor

This probably needs to be added to the instance template resource too. I'm going to suggest @lwander finish this off but thanks @haklop for getting us most of the way there :)

@sparkprime
Copy link
Contributor

Thanks for the headstart, @haklop! I'm closing this as the feature is now in.

@sparkprime sparkprime closed this Nov 2, 2015
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants