Add CreateBeforeDestroy to instance state #24084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sdkv1
Added to src and object, but still need serialization and tests.
If the Diff is only a delete action, we can't override CreateBeforeDestroy, because it will always be false and prevent the stored state value from being used.
Even though this is only the destroy half of CreateBeforeDestroy, the resource may still require the same destroy order.
If the resource was stored as CreateBeforeDestroy, use the same ordering regardless. This reversal will be taken care if more cleanly in state-only destroys, and with less risk. Don't use this commit as-is.
jbardin
force-pushed
the
jbardin/cbd-instance-state
branch
from
141d3e3
to
691bb6b
Compare
Codecov Report
@@ Coverage Diff @@
## master #24084 +/- ##
=========================================
Coverage ? 56.94%
=========================================
Files ? 656
Lines ? 59228
Branches ? 0
=========================================
Hits ? 33730
Misses ? 22486
Partials ? 3012
Continue to review full report at Codecov.
|
mildwonkey
approved these changes
Mar 9, 2020
noahmercado
pushed a commit
to noahmercado/terraform
that referenced
this pull request
Apr 8, 2020
…e-state Add CreateBeforeDestroy to instance state
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally
CreateBeforeDestroyis only used from the configuration, because it's primarily thought of in the operation ordering for instance replacement. It however also effects dependent resource operations by updating the dependent before destroying the CBD instance. We need to storeCreateBeforeDestroyin the state, because that is the only way to record the proper ordering for dependent resource updates when a resource is removed from the config.Fixes: #23635, along with numerous issues that have misdiagnosed in providers, where updates are applied in the wrong order when removing dependent resources.