Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure backend storage sdk #24669

Merged
merged 15 commits into from
May 20, 2020
Merged

Update azure backend storage sdk #24669

merged 15 commits into from
May 20, 2020

Conversation

mbfrahry
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #24669 into master will decrease coverage by 0.02%.
The diff coverage is 0.78%.

Impacted Files Coverage Δ
backend/remote-state/azure/arm_client.go 11.11% <0.00%> (-2.53%) ⬇️
backend/remote-state/azure/backend_state.go 0.00% <0.00%> (ø)
backend/remote-state/azure/client.go 0.00% <0.00%> (ø)
backend/remote-state/azure/backend.go 95.91% <100.00%> (+0.02%) ⬆️
helper/resource/state.go 85.47% <0.00%> (-0.86%) ⬇️
terraform/evaluate.go 53.15% <0.00%> (-0.46%) ⬇️

@ghost ghost added the sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK label Apr 15, 2020
@tombuildsstuff tombuildsstuff self-requested a review April 16, 2020 16:11
@mbfrahry mbfrahry changed the title [WIP] Update azure backend storage sdk Update azure backend storage sdk Apr 20, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things but these otherwise LGTM 👍

backend/remote-state/azure/backend_state.go Show resolved Hide resolved
backend/remote-state/azure/backend_state.go Outdated Show resolved Hide resolved
backend/remote-state/azure/client.go Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor

Tests pass:

$ TF_AZURE_TEST=1 envchain azurerm go test -v ./backend/remote-state/azure/ -timeout=60m
=== RUN   TestBackend_impl
--- PASS: TestBackend_impl (0.00s)
=== RUN   TestBackendConfig
--- PASS: TestBackendConfig (0.00s)
=== RUN   TestBackendAccessKeyBasic
--- PASS: TestBackendAccessKeyBasic (130.21s)
=== RUN   TestBackendManagedServiceIdentityBasic
--- SKIP: TestBackendManagedServiceIdentityBasic (0.00s)
=== RUN   TestBackendSASTokenBasic
--- PASS: TestBackendSASTokenBasic (114.67s)
=== RUN   TestBackendServicePrincipalBasic
--- PASS: TestBackendServicePrincipalBasic (131.59s)
=== RUN   TestBackendServicePrincipalCustomEndpoint
--- SKIP: TestBackendServicePrincipalCustomEndpoint (0.00s)
=== RUN   TestBackendAccessKeyLocked
--- PASS: TestBackendAccessKeyLocked (128.45s)
=== RUN   TestBackendServicePrincipalLocked
--- PASS: TestBackendServicePrincipalLocked (128.32s)
=== RUN   TestRemoteClient_impl
--- PASS: TestRemoteClient_impl (0.00s)
=== RUN   TestRemoteClientAccessKeyBasic
--- PASS: TestRemoteClientAccessKeyBasic (111.05s)
=== RUN   TestRemoteClientManagedServiceIdentityBasic
--- SKIP: TestRemoteClientManagedServiceIdentityBasic (0.00s)
=== RUN   TestRemoteClientSasTokenBasic
--- PASS: TestRemoteClientSasTokenBasic (126.44s)
=== RUN   TestRemoteClientServicePrincipalBasic
--- PASS: TestRemoteClientServicePrincipalBasic (112.29s)
=== RUN   TestRemoteClientAccessKeyLocks
--- PASS: TestRemoteClientAccessKeyLocks (126.90s)
=== RUN   TestRemoteClientServicePrincipalLocks
--- PASS: TestRemoteClientServicePrincipalLocks (128.15s)
=== RUN   TestPutMaintainsMetaData
--- PASS: TestPutMaintainsMetaData (126.71s)
PASS
ok  	github.com/hashicorp/terraform/backend/remote-state/azure	1364.877s

@tombuildsstuff tombuildsstuff merged commit 481b03c into master May 20, 2020
@tombuildsstuff tombuildsstuff deleted the p-azure-autorest branch May 20, 2020 15:29
tombuildsstuff added a commit that referenced this pull request May 20, 2020
@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend/azure sdkv1 [PRs only] Marks changes that may potentially need to be ported to the plugi nSDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants