backend/local: revert duplicate ctx creation #26041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the backend had a side effect of causing all input vars to be requested twice (due to two calls to `contextDirect`) and provider input values to be omitted entirely (those were populated during Validate, but Validate was called on the "extra" context and not the returned context). This PR adds a Context.StatelessCopy function which returns a nearly-identical copy of a terraform.Context with the state "zeroed out", which can then be Validate()d. A better, future refactor should remove the need for this function and instead modify Validate() itself to ignore state. Fixes #26027 I've added tests that confirm both behaviors; I am not sure what test covers the behavior that lead to this change in the first place but I did verify locally using the reproduction in the original PR.
Codecov Report
|
|
SO CLOSE! There's an eval node called in Validate which is updating state, and that seems to be the root of that one test failure. I'll try again monday. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the local backend had a side effect of causing all input vars to be requested twice (due to two calls to
contextDirect) andprovider input values to be requested but not stored (those were populated
during Validate, but Validate was called on the "extra" context and not
the returned context).
This PR modifies the graphWalker to substitute an empty state when creating the validate graph.
Fixes #26027 and #26035
I've modified and added tests to confirm both problems input var problems have been fixed; I do not think there's a test that covers the earlier issue. I verified that it's still fixed locally using the reproduction in the original issue: (#25752)