Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for aws_ecs_task_definition, to avoid confusion. #2609

Merged
merged 3 commits into from
Jul 3, 2015
Merged

Updated docs for aws_ecs_task_definition, to avoid confusion. #2609

merged 3 commits into from
Jul 3, 2015

Conversation

CpuID
Copy link
Contributor

@CpuID CpuID commented Jul 2, 2015

For #2606

@CpuID
Copy link
Contributor Author

CpuID commented Jul 2, 2015

cc @radeksimko

@@ -12,6 +12,8 @@ Provides an ECS task definition to be used in `aws_ecs_service`.

## Example Usage

### jenkins.tf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you omit this header/filename since it's not substantial for this example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CpuID I meant just the header/filename, not everything. 😉

@radeksimko radeksimko added the waiting-response An issue/pull request is waiting for a response from the community label Jul 3, 2015
@CpuID
Copy link
Contributor Author

CpuID commented Jul 3, 2015

@radeksimko hows that look? added one extra bit under the jenkins.json file, otherwise verbatim.

@CpuID
Copy link
Contributor Author

CpuID commented Jul 3, 2015

@radeksimko oops ... better :)

@radeksimko radeksimko removed the waiting-response An issue/pull request is waiting for a response from the community label Jul 3, 2015
radeksimko added a commit that referenced this pull request Jul 3, 2015
Updated docs for aws_ecs_task_definition, to avoid confusion.
@radeksimko radeksimko merged commit 8d6e2eb into hashicorp:master Jul 3, 2015
@aarcro
Copy link

aarcro commented Jun 6, 2016

Finally understood this. It should have been obvious but the value of container_definitions in terraform is what you would put in the "containerDefinitions" key in your AWS task json file. That's a list of objects with keys like name, image, links, ...

@radeksimko
Copy link
Member

@aarcro how would you make it more obvious than it is today? (PRs/suggestions welcomed 😉 )

@aarcro
Copy link

aarcro commented Jun 6, 2016

I just meant it should have been obvious to me from reading, but it wasn't. Now that I've tried 10 JSON structures I understand the errors, and what the docs we're trying to say from the get go. It's worded exactly right, but an example might help.

@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants