-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs for aws_ecs_task_definition, to avoid confusion. #2609
Updated docs for aws_ecs_task_definition, to avoid confusion. #2609
Conversation
cc @radeksimko |
@@ -12,6 +12,8 @@ Provides an ECS task definition to be used in `aws_ecs_service`. | |||
|
|||
## Example Usage | |||
|
|||
### jenkins.tf | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you omit this header/filename since it's not substantial for this example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CpuID I meant just the header/filename, not everything. 😉
@radeksimko hows that look? added one extra bit under the jenkins.json file, otherwise verbatim. |
@radeksimko oops ... better :) |
Updated docs for aws_ecs_task_definition, to avoid confusion.
Finally understood this. It should have been obvious but the value of |
@aarcro how would you make it more obvious than it is today? (PRs/suggestions welcomed 😉 ) |
I just meant it should have been obvious to me from reading, but it wasn't. Now that I've tried 10 JSON structures I understand the errors, and what the docs we're trying to say from the get go. It's worded exactly right, but an example might help. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
For #2606