Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: don't prompt for variables with defaults #2613

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Commits on Jul 2, 2015

  1. core: don't prompt for variables with defaults

    In `helper/schema` we already makes a distinction between `Default`
    which is always applied and `InputDefault` which is displayed to the
    user for an empty field.
    
    But for variables we just have `Default` which is treated like
    `InputDefault`. This changes it to _not_ prompt the user for a value
    when the variable declaration includes a default.
    
    Treating this as a UX bugfix and the "don't prompt for variables w/
    defaults set" behavior as the originally expected behavior we were
    failing to honor.
    
    Added an already-passing test to verify and cover the `helper/schema`
    behavior.
    
    Perhaps down the road we can add a `input_default` attribute to
    variables to allow similar behavior to `helper/schema` in variables, but
    for now just sticking with the fix.
    
    Fixes #2592
    phinze committed Jul 2, 2015
    Configuration menu
    Copy the full SHA
    5c38456 View commit details
    Browse the repository at this point in the history