Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/cloudstack: add new provider option and some more... #2753

Merged
merged 3 commits into from
Jul 16, 2015
Merged

provider/cloudstack: add new provider option and some more... #2753

merged 3 commits into from
Jul 16, 2015

Conversation

svanharmelen
Copy link
Contributor

  • Added a new provider option to only use HTTP GET calls (needed by some cloud providers)
  • Updated a few resources (incl. their docs) so you can supply either a resource name or ID
  • Added a retry func for creating ACL rules, as sometimes creating the the ACL and it's rules to fast will cause the rule creation to fail
  • Added a new resource cloudstack_secondary_ipaddress incl. tests and docs

Executed all (acceptance) tests after the last commit, which executed without any errors.

@svanharmelen
Copy link
Contributor Author

@phinze if you have a minute to do a quick review, that would be great!

@phinze
Copy link
Contributor

phinze commented Jul 16, 2015

LGTM!

@svanharmelen
Copy link
Contributor Author

@phinze thanks!

svanharmelen pushed a commit that referenced this pull request Jul 16, 2015
provider/cloudstack: add new provider option and some more...
@svanharmelen svanharmelen merged commit 0308390 into hashicorp:master Jul 16, 2015
@svanharmelen svanharmelen deleted the f-cloudstack-options branch July 22, 2015 18:57
@larstobi
Copy link

@svanharmelen Thanks! 👍

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants