Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix issue with toggling monitoring in AWS Instances #2794

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 20, 2015

Fixes #2688 by checking a change in monitoring and calling MonitorInstances or UnmonitorInstances accordingly

@phinze
Copy link
Contributor

phinze commented Jul 21, 2015

LGTM

catsby added a commit that referenced this pull request Jul 21, 2015
provider/aws: Fix issue with toggling monitoring in AWS Instances
@catsby catsby merged commit 81957f7 into master Jul 21, 2015
@catsby catsby deleted the b-aws-instance-monitoring branch July 21, 2015 15:22
@joshgarnett
Copy link

@catsby nice find! Sorry for the bug, I'll keep this in mind for future PRs I create.

@catsby
Copy link
Contributor Author

catsby commented Jul 29, 2015

@joshgarnett no apologies needed, thanks for the contribution 😄

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_instance Changing monitoring argument doesn't change an instance
3 participants