Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document that destroy provisioners don't run with create_before_destroy #28345

Merged
merged 2 commits into from
Sep 3, 2021
Merged

document that destroy provisioners don't run with create_before_destroy #28345

merged 2 commits into from
Sep 3, 2021

Conversation

yvespp
Copy link
Contributor

@yvespp yvespp commented Apr 13, 2021

Documents issue #13549

Ran in this today again after first running into it a year ago and forgetting about it...
I think it's better to document this so people don't try to use this and then just end up disappointed because it doesn't work.

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yvespp
Copy link
Contributor Author

yvespp commented Apr 13, 2021

https://packer.io/ redirects to https://www.packer.io/. Should I update the link in the docs?

laurapacilio
laurapacilio reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - We appreciate you making the effort to document this, as it's clearly an issue that folks care deeply about! I made a few edits just to comply with our style guide - see what you think!

website/docs/language/meta-arguments/lifecycle.html.md Outdated Show resolved Hide resolved
website/docs/language/resources/provisioners/syntax.html.md Outdated Show resolved Hide resolved
@laurapacilio laurapacilio added the tw-reviewed Technical Writing has reviewed this PR. label Sep 2, 2021
@yvespp @laurapacilio
Apply suggestions from code review
fa4c590 
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
@yvespp
Copy link
Contributor Author

yvespp commented Sep 3, 2021

Thanks for the review!

@laurapacilio
Copy link
Contributor

Merging even though link checker is failing because the Packer website link isn't really broken :-)

@laurapacilio laurapacilio merged commit 1e1d47d into hashicorp:main Sep 3, 2021
@yvespp yvespp deleted the destroy_provisioners_doc branch September 6, 2021 15:07
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurapacilio laurapacilio laurapacilio left review comments

Assignees
No one assigned
Labels
documentation tw-reviewed Technical Writing has reviewed this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvespp @hashicorp-cla @laurapacilio