Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix issue in Security Group Rules where the Security Group is not found #2897

Merged
merged 1 commit into from
Jul 30, 2015

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 30, 2015

After creation, if a security group is destroyed, a Security Group Rule set the id to "" but did not return, causing a panic down the road.

This is an alternative to #2797

Fixes #2845
Fixes #2593

@catsby
Copy link
Contributor Author

catsby commented Jul 30, 2015

Thanks to @thegedge for digging in on #2797 and finding the core of the issue, and @phinze for pointing out what I should have seen earlier 😄

@phinze
Copy link
Contributor

phinze commented Jul 30, 2015

LGTM

catsby added a commit that referenced this pull request Jul 30, 2015
provider/aws: Fix issue in Security Group Rules where the Security Group is not found
@catsby catsby merged commit 6263d7b into master Jul 30, 2015
@catsby catsby deleted the b-aws-sg-rule-ref branch July 30, 2015 21:12
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants