Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: dag errors should cascade to all descendents #2963

Merged
merged 1 commit into from
Aug 7, 2015
Merged

core: dag errors should cascade to all descendents #2963

merged 1 commit into from
Aug 7, 2015

Commits on Aug 7, 2015

  1. core: dag errors should cascade to all descendents 

    We weren't marking skipped nodes as failing, so any
grandchild-and-deeper dependencies would still evaluate.

For example:

    A -> B -> C -> D

If B failed, C would be skipped, but D would still be evaluated.

This fixes the behavior so C, D, and any further descendents will all be
skipped when B fails.

Addresses crashing aspect of #2955 and likely a lot of other confusing
failure modes.
    @phinze
    phinze committed Aug 7, 2015
    Configuration menu
    Copy the full SHA
    baa33d7 View commit details
    Browse the repository at this point in the history