-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/azurerm: adding support for authenticating via MSAL in addition to ADAL #29968
Conversation
…secret This redirects to the registry so we should point there directly
…e_microsoft_graph` field
Client Certificate Tests:
MSI Tests:
Other Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @tombuildsstuff. Just a couple small wording suggestions but otherwise LGTM 👍
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
Co-authored-by: Tom Bamford <tbamford@hashicorp.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds support for using MSAL instead of ADAL for getting auth tokens in the AzureRM backend, meaning that Microsoft Graph Tokens will be used rather than Azure Active Directory Graph Tokens.
For the moment this is an opt-in feature - however in a future release we'll flip the default from
ADAL
toMSAL
since ADAL is deprecated.