Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for CloudTrail #3094

Merged
merged 3 commits into from
Oct 29, 2015

Conversation

radeksimko
Copy link
Member

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=CloudTrail' 2>/dev/null
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=CloudTrail -timeout 90m
=== RUN TestAccAWSCloudTrail_basic
--- PASS: TestAccAWSCloudTrail_basic (16.34s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    16.353s

I wanted to add some more complicated examples into acc. tests, e.g. with SNS, but I struggled to get the policy right and we don't have support for CloudWatch Log Groups yet either.

@catsby
Copy link
Contributor

catsby commented Oct 28, 2015

This too looks great, thanks @radeksimko ! Merge away

radeksimko added a commit that referenced this pull request Oct 29, 2015
provider/aws: Add support for CloudTrail
@radeksimko radeksimko merged commit 678c7e9 into hashicorp:master Oct 29, 2015
@radeksimko radeksimko deleted the f-aws-cloudtrail branch October 29, 2015 07:03
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants