Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optional content field to s3_bucket_object #3200

Merged
merged 4 commits into from
Oct 10, 2015
Merged

Adding optional content field to s3_bucket_object #3200

merged 4 commits into from
Oct 10, 2015

Conversation

zpatrick
Copy link
Contributor

@zpatrick zpatrick commented Sep 9, 2015

Added an optional field, content, for an easy way to pass things like rendered templates to s3:

resource "aws_s3_bucket_object" "example" {
    bucket = "some_bucket"
    key = "/path/to/file.txt"
    content = "${template_file.example.rendered}"
}

resource "template_file" "example" {
    filename = "/templates/example.txt"
    vars {
        name = "${var.name}"
    }
}

I also made source optional + conflicting with content.

@apparentlymart
Copy link
Contributor

Thanks for doing this! I've been wishing for this for a while.

I wrote some simple docs for this in zpatrick/terraform#1 .

It'd also be great if you could run go fmt on your source files to match with the prevailing style. In particular it looks like some spaces (vs. tabs) crept into resource_aws_s3_bucket_object.go and made the indentation a little wonky as a result.

zpatrick and others added 2 commits September 10, 2015 18:37
@zpatrick
Copy link
Contributor Author

Thanks, @apparentlymart !

@mnylen
Copy link

mnylen commented Sep 21, 2015

When this could be released? We're badly in need for this. :)

@gtmtech
Copy link

gtmtech commented Oct 9, 2015

+1 - can this be merged ASAP, this would be so useful

apparentlymart added a commit that referenced this pull request Oct 10, 2015
Optional "content" argument for "s3_bucket_object"
@apparentlymart apparentlymart merged commit a888cd6 into hashicorp:master Oct 10, 2015
bmcustodio pushed a commit to bmcustodio/terraform that referenced this pull request Sep 26, 2017
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants