Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/s3: Adds https_proxy and no_proxy parameters #34243

Merged
merged 2 commits into from
Nov 15, 2023
Merged

backend/s3: Adds https_proxy and no_proxy parameters #34243

merged 2 commits into from
Nov 15, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 14, 2023 •
edited
Loading

Adds parameters https_proxy and no_proxy to correctly configure proxies.

Fixes #33987
Fixes #34183

Target Release

1.6.4

Draft CHANGELOG entry

BUG FIXES

  • backend/s3: Adds https_proxy and no_proxy parameters to allow fully specifying proxy configuration

@gdavison gdavison requested a review from a team as a code owner November 14, 2023 21:57
@gdavison gdavison added backend/s3 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Nov 14, 2023
This was referenced Nov 14, 2023
Open
Closed
@radeksimko radeksimko mentioned this pull request Nov 15, 2023
Closed
jar-b
jar-b approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 143.152s

@jar-b jar-b merged commit 532bc60 into main Nov 15, 2023
7 checks passed
@jar-b jar-b deleted the s3/b-proxy-settings branch November 15, 2023 15:08
@github-actions GitHub Actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Nov 15, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @jar-b