Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add issensitive function #34619

Merged
merged 1 commit into from
Feb 6, 2024
Merged

add issensitive function #34619

merged 1 commit into from
Feb 6, 2024

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Feb 5, 2024 •
edited
Loading

This function can be used to check if a value is marked as
sensitive or not within terraform.

Fixes #34572

Target Release

1.8.x

Draft CHANGELOG entry

NEW FEATURES

  • Add issensitive terraform function to detect if a value is marked as sensitive

@DanielMSchmidt DanielMSchmidt force-pushed the add-is-sensitive-function branch 2 times, most recently from 3ea469e to 473da98 Compare February 5, 2024 15:03
liamcervante
liamcervante reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just the nav bar link a bit out of place.

internal/lang/funcs/sensitive_test.go Outdated Show resolved Hide resolved
website/data/language-nav-data.json Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the add-is-sensitive-function branch from 473da98 to 2832e7f Compare February 5, 2024 15:39
@DanielMSchmidt
add issensitive function
3a77065 
This function can be used to check if a value is marked as
sensitive or not within terraform.

Closes hashicorp#34572
@DanielMSchmidt DanielMSchmidt force-pushed the add-is-sensitive-function branch from 2832e7f to 3a77065 Compare February 5, 2024 15:45
liamcervante
liamcervante approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbanck dbanck mentioned this pull request Feb 5, 2024
Closed
@DanielMSchmidt DanielMSchmidt merged commit ccf8bb2 into hashicorp:main Feb 6, 2024
7 checks passed
@DanielMSchmidt DanielMSchmidt deleted the add-is-sensitive-function branch February 6, 2024 10:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test whether a value is sensitive
2 participants
@DanielMSchmidt @liamcervante