fix panic when import id is empty string #34625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
throw-better-error-if-import-id-is-empty-string
branch
from
f9b321a to
14a8009
Compare
DanielMSchmidt
force-pushed
the
throw-better-error-if-import-id-is-empty-string
branch
2 times, most recently
from
5614e92 to
e0cb633
Compare
DanielMSchmidt
force-pushed
the
throw-better-error-if-import-id-is-empty-string
branch
from
e0cb633 to
a281646
Compare
liamcervante
reviewed
Feb 7, 2024
DanielMSchmidt
force-pushed
the
throw-better-error-if-import-id-is-empty-string
branch
from
a281646 to
f56b19a
Compare
We can only detect this during evaluation since the import id is an hcl expression. Fixes #33505
DanielMSchmidt
force-pushed
the
throw-better-error-if-import-id-is-empty-string
branch
from
f56b19a to
2b7c7b2
Compare
liamcervante
approved these changes
Feb 7, 2024
DanielMSchmidt
added
the
1.7-backport
DanielMSchmidt
deleted the
throw-better-error-if-import-id-is-empty-string
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only detect this during evaluation since the import id is an hcl expression
Fixes #33505
Target Release
1.7.x
Draft CHANGELOG entry
BUG FIXES