Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configs: Don't treat module_variable_optional_attrs as special #34752

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

apparentlymart
Copy link
Contributor

Due to some specific circumstances around how this experiment reached stabilization we made a planned-temporary exception to make it valid to specify even in non-alpha builds of Terraform, just to be able to return a more precise error message.

The comment added at the time suggested that we remove this "a release or two after v1.3", and v1.8 is the actively-developed release at the time I'm writing this so we've kept this around far longer than we originally felt we needed to. It's time for it to go.

This particular experiment will now get the same treatment as all others when used in a non-alpha release: Terraform will return the general error about experiments only being available in alpha releases. Since this experiment has concluded, it will also return an error in alpha releases, but one that talks specifically about the conclusion of this experiment.

Due to some specific circumstances around how this experiment reached
stabilization we made a planned-temporary exception to make it valid to
specify even in non-alpha builds of Terraform, just to be able to return
a more precise error message.

The comment added at the time suggested that we remove this "a release or
two after v1.3", and v1.8 is the actively-developed release at the time
I'm writing this so we've kept this around far longer than we originally
felt we needed to. It's time for it to go.

This particular experiment will now get the same treatment as all others
when used in a non-alpha release: Terraform will return the general error
about experiments only being available in alpha releases.
@apparentlymart apparentlymart merged commit 071b6de into main Mar 1, 2024
10 checks passed
@apparentlymart apparentlymart deleted the f-optionalattrs-experiment-nonspecial branch March 1, 2024 15:20
Copy link

github-actions bot commented Mar 1, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants