Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS SDK versions to the latest #34796

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Conversation

kojoru
Copy link
Contributor

@kojoru kojoru commented Mar 8, 2024

This pull request updates the AWS SDKs to the latest version.

The intent is to fix #34528, which is intermittent and can't be easily reproduced.

The root cause was discussed in the relevant AWS SDK issue and AWS folks couldn't reproduce this situation on the latest versions of their SDK.

Hence, this pull request.

Target Release

1.7.x, 1.8.x

Draft CHANGELOG entry

BUG FIXES

  • When using s3 backend and encountering a network issue, the retry code would fail with "failed to rewind transport stream for retry". Now the retry should be successful.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented Mar 8, 2024

I've notified the teams responsible for triaging S3 backend related issues. Thanks for this submission.

@gdavison gdavison self-assigned this Mar 8, 2024
@gdavison gdavison added 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Mar 8, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, @kojoru

@gdavison gdavison merged commit e2c5957 into hashicorp:main Mar 8, 2024
5 of 6 checks passed
Copy link

github-actions bot commented Mar 8, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@scottmchargue-eb
Copy link

#34528 occurs for us frequently in or ci/cd process on our self-hosted runners in aws. It occurs most frequently when there are no changes to the plan but the state is being updated anyway. It also occurs quite frequently when there are many quick updates to the s3 bucket for very fast operations on items that do not take much time to deploy. It has never occured for me when we run locally only on our cicd runners hosted in aws.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 bucket rewind error when running apply
5 participants