provider/aws: Additional error checking to VPC Peering conn

[catsby]

Add additional error checking to VPC Peering connection, to try and catch/prevent #3145 and #2690

Unfortunately I have not been able to reproduce either using this config:

resource "aws_vpc" "foo" {
        cidr_block = "10.0.0.0/16"
}

resource "aws_vpc" "bar" {
        cidr_block = "10.1.0.0/16"
}

resource "aws_vpc_peering_connection" "foo" {
        vpc_id = "${aws_vpc.foo.id}"
        peer_vpc_id = "${aws_vpc.bar.id}"
        tags {
            foo = "bar"
        }
    auto_accept = true
}

Regardless, there were some places in the code that could use some additional checks

[phinze]

LGTM

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.