Fix partial address representation in plan for deferred actions #34966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not particularly sure what is causing those errors, but hopefully they'll go away once I import a real version of HCL :/ |
nfagerlund
reviewed
Apr 18, 2024
liamcervante
force-pushed
the
liamcervante/deferred-instance-keys
branch
from
3e1ef28 to
d4e7bf3
Compare
liamcervante
requested review from
nfagerlund and
a team
and removed request for
a team
jbardin
approved these changes
Jun 19, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the partial plan address representation to use
[*]instead of["*"].To do this it needs the latest version of HCL which includes an updated traversal parse function that supports the new
[*]instance key within a traversal. This change is completely additive, so there is no breaking change. The new functions that accept the new instance key are only referenced from within the deferred changes parsing of the plan.