Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: Remove deprecated assume role attributes #35721

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

gdavison
Copy link
Contributor

Removes deprecated fields from S3 backend for assuming IAM roles outside of the assume_role block.

Target Release

1.10.0

Draft CHANGELOG entry

UPGRADE NOTES

  • backend/s3: Removes deprecated attributes for assuming IAM role. Must use the assume_role block.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Needs a changelog entry (or alternatively a note in the upgrade guide?)

% TF_ACC=1 go test ./...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 146.910s

@gdavison gdavison merged commit c00274f into main Sep 23, 2024
7 checks passed
@gdavison gdavison deleted the s3/td-remove-deprecated-assume-role branch September 23, 2024 18:15
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants