Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: Revert IAM role chaining support #35827

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 8, 2024

The PR #35720 introduced a breaking change to the S3 backend

IAM role chaining will be re-introduced at a later date

Fixes #35816

Draft CHANGELOG entry

No CHANGELOG entry: reverts feature only present in alpha build

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if my approval works here but LGTM 😢

@gdavison gdavison merged commit 0be94d4 into main Oct 9, 2024
6 checks passed
@gdavison gdavison deleted the s3/revert-f-role-chaining branch October 9, 2024 00:36
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.10.0-alpha20240926] "An argument definition must end with a newline." for assume_role
2 participants