Ephemeral expansion and add tests for ephemeral values #35833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
ephemeral-values-add-tests
branch
from
4221c68
to
e693342
Compare
DanielMSchmidt
force-pushed
the
ephemeral-values-add-tests
branch
from
c77528f
to
1580f7d
Compare
radeksimko
approved these changes
Oct 14, 2024
DanielMSchmidt
force-pushed
the
ephemeral-values-add-tests
branch
from
6c8d688
to
422970f
Compare
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
DanielMSchmidt
force-pushed
the
ephemeral-values-add-tests
branch
from
422970f
to
1ba063e
Compare
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we check for ephemeral values for all possible expansions (for_each / count on resource / module / import).
It also refactors the plan tests and adds a lot of new tests for everything I could find in the RFC, some are skipped to leave the implementation to future PRs.
Target Release
1.10.x
Draft CHANGELOG entry
ENHANCEMENTS