moved: error if not targeting a resource address

[liamcervante]

This PR updates the parsing of targets (such as within import and moved blocks) so that they respect the keywords reserved by the top level references within Terraform.

These keywords include things like local, each, count, self, and terraform. Previously it was possible to reference these from within moved as resource types without prefixing them with the normally required resource. identifier to differentiate between a resource with the type name local and just referencing a local variable.

I'm not backporting this change, as it is technically a breaking change though I doubt anyone will be affected. Anyone who uses a resource that is simple called local (or any other reserved keyword) would previously have been able to reference it directly from a moved block. This will start failing, and they must add in the .resource prefix to make things work again.

The purpose of this change is to protect users from trying to reference input or local variables, which currently makes Terraform just ignore the moved block. I don't think many (if any) providers have actually made resource types that match keywords so this should hopefully not breaking anything.

Fixes #35840

Target Release

1.10.x

Draft CHANGELOG entry

UPGRADE NOTES

• moved blocks: Moved blocks now respect reserved keywords when parsing resource addresses. Configurations that reference resources with type names that match top level blocks and keywords will need to be updated to

[jbardin]

Targets are often groups of instances, so I think just "reference" here would be the correct type for documentation purposes.

[liamcervante]

Done!

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.