Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new auth for tencentcloud cos backend #35888

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Conversation

SevenEarth
Copy link
Contributor

@SevenEarth SevenEarth commented Oct 22, 2024

Add more authentication method for COS backend.

Target Release

1.19.x

Draft CHANGELOG entry

ENHANCEMENTS

  • Support shared_credentials_dir, profile authentication method
  • Support cam_role_name authentication method
  • Updated documentation for TencentCloud cos backend

Copy link

hashicorp-cla-app bot commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


seanyyan seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@SevenEarth
Copy link
Contributor Author

@crw Hello, I've signed the CLA, Please review this pr. thanks

@SevenEarth
Copy link
Contributor Author

@crw Hi, I've signed the CLA, Please review this pr. thanks

@jbardin
Copy link
Member

jbardin commented Oct 31, 2024

cc @likexian, listed as the codeowner for this backend

@SevenEarth
Copy link
Contributor Author

Hi @likexian, pls help to review my PR. 3q.

@likexian
Copy link
Contributor

likexian commented Nov 4, 2024

LGTM

@SevenEarth
Copy link
Contributor Author

@jbardin Hi, could you please take a look at this pr, thanks?

@SevenEarth SevenEarth requested a review from a team as a code owner November 11, 2024 06:41
@SevenEarth
Copy link
Contributor Author

@crw @jbardin @likexian This PR has been submitted for some time now, Please take a look at this pr? thanks

@radeksimko radeksimko merged commit 7921b13 into hashicorp:main Nov 13, 2024
7 checks passed
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@SevenEarth
Copy link
Contributor Author

Thanks ^_^

@radeksimko radeksimko added 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Nov 13, 2024
radeksimko pushed a commit that referenced this pull request Nov 13, 2024
* add new auth for tencentcloud cos backend

* add new auth for tencentcloud cos backend

* add
radeksimko added a commit that referenced this pull request Nov 13, 2024
* add new auth for tencentcloud cos backend

* add new auth for tencentcloud cos backend

* add

Co-authored-by: SevenEarth <45937856+SevenEarth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/cos enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants