don't error on eval of missing instances #35895
Merged
+65
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While in most cases a missing instance during evaluation would be a bug in terraform, the insertion of postconditions into instance planning has created a situation where not all instances will be available when GetResource is called. We do have a special context for evaluating self alone, but postconditions also need to have the module context available too. We may be able to come up with some other way to create an evaluation context which handles self more selectively, but that looks like a large change for a situation which should not otherwise happen. If this were to mask a legitimate error, the fact that an unexpected DyanamicVal were encountered will raise the problem again, and we can correlate that with the logged warning.
liamcervante
approved these changes
Oct 24, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in most cases a missing instance during evaluation would be a bug in terraform, the insertion of postconditions into instance planning has created a situation where not all instances will be available when
GetResourceis called. We do have a special context for evaluatingselfalone, but postconditions also need to have the module context available too.We may be able to come up with some other way to create an evaluation context which handles
selfmore selectively, but that looks like a large change for a situation which should not otherwise happen. If this were to mask a legitimate error, the fact that an unexpectedDynamicValwere encountered will raise the problem again, and we can correlate that with the logged warning.Fixes #34310