Backport of command/views: Attempt to fix flaky JSON hook test into v1.10 #35947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
backport/radek/t-fix-flaky-ui-hook-test-json/cheaply-major-firefly
branch
from
e5473d2 to
11122e1
Compare
radeksimko
approved these changes
Nov 4, 2024
radeksimko
deleted the
backport/radek/t-fix-flaky-ui-hook-test-json/cheaply-major-firefly
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #35940 to be assessed for backporting due to the inclusion of the label 1.10-backport.
The below text is copied from the body of the original PR.
This is in reaction to a failure indicated in the CI:
https://github.com/hashicorp/terraform/actions/runs/11628307687/job/32383225309#step:6:91
Again - not ideal to use
time.Sleepin general but the fix of the other test appears to have addressed the flakiness for now in #35927Overview of commits