Execute equivalence tests on every pull request #35976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| git commit -m "Update equivalence test golden files." | ||
| git push --set-upstream origin ${{ inputs.new-branch }} | ||
|
|
||
| - name: "create pull request" |
There was a problem hiding this comment.
I think this would require
permissions:
contents: write
pull-requests: write
or is it enough to have this in the invoking github action without explicitly passing down the GITHUB_TOKEN var?
There was a problem hiding this comment.
I think because it is a composite action it inherits the permissions from the caller.
DanielMSchmidt
approved these changes
Nov 18, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CI system. Now, the equivalence tests will execute on every pull request instead of
neverafter each release. This makes it easier to pinpoint the source of any unwanted diffs.For now, the equivalence test actions and feedback are not required. Any errors can be ignored so as not to block merging while we iron out potential issues. Later we should come back and mark these new actions as required.
The process is as follows:
diffmode. This will produce a report showing any differences, and comment on the PR if diffs are found.updatemode. This will update the golden files in the repository, and open a new PR with the changes for review and merge by whoever merged the PR.The equivalence tests are testing the json and human readable outputs, so 99% of PRs will not be affected by these changes.