Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Update CODEOWNERS #35988

Merged
merged 3 commits into from
Nov 12, 2024
Merged

github: Update CODEOWNERS #35988

merged 3 commits into from
Nov 12, 2024

Conversation

xiehan
Copy link
Member

@xiehan xiehan commented Nov 12, 2024

Make the Education team (shared) codeowners of the docs on the website so that they can approve docs-only PRs as well. We don't need to be gatekeepers for those kinds of changes.

Make the Education team (shared) codeowners of the docs on the website so that they can approve docs-only PRs as well. We don't need to be gatekeepers for those kinds of changes.
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion, LGTM

CODEOWNERS Outdated Show resolved Hide resolved
xiehan and others added 2 commits November 12, 2024 15:07
Co-authored-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
Co-authored-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
@xiehan xiehan merged commit 2ac7af3 into main Nov 12, 2024
10 checks passed
@xiehan xiehan deleted the xiehan-patch-1 branch November 12, 2024 14:19
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@radeksimko radeksimko added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 13, 2024
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants