Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Update CODEOWNERS #36000

Merged
merged 1 commit into from
Nov 14, 2024
Merged

github: Update CODEOWNERS #36000

merged 1 commit into from
Nov 14, 2024

Conversation

xiehan
Copy link
Member

@xiehan xiehan commented Nov 13, 2024

I met with @mdeggies' taskforce today and we figured out that if we want the Core team to still be able to approve & merge PRs that affect the backends without having approvals be required from the provider teams is to add our team as CODEOWNERS of these specific directories as well.

I met with @mdeggies' taskforce today and we figured out that if we want the Core team to still be able to approve & merge PRs that affect the backends without having approvals be _required_ from the provider teams is to add our team as CODEOWNERS of these specific directories as well.
@xiehan xiehan merged commit dda25d1 into main Nov 14, 2024
10 checks passed
@xiehan xiehan deleted the xiehan-patch-1 branch November 14, 2024 15:26
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

dbanck pushed a commit to dbanck/terraform that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants