Remove Interpolation-only expressions from website/docs files

[nimzo6689]

Interpolation-only expressions are deprecated in Terraform v0.12.14.
See. terraform_deprecated_interpolation - tflint-ruleset-terraform

Fixes #36064

Target Release

1.x.x

[hashicorp-cla-app]

All committers have signed the CLA.

[bschaatsbergen]

Hey @nimzo6689, thank you for taking the time to submit a PR and make these updates!

[radeksimko]

Thank you for the PR. It is true this syntax has long been deprecated.

We normally do not accept PRs which do cleanup across the codebase and nothing else for various reasons - mostly ones that have to do with git history and conflicts with pending PRs. However, I think in this particular case we could make an exception.

With that in mind, would you mind also addressing the remaining 7 cases?

./website/docs/language/backend/gcs.mdx:  content  = "${data.terraform_remote_state.foo.greeting}"
./website/docs/language/backend/s3.mdx:    role_arn = "${var.workspace_iam_roles[terraform.workspace]}"
./website/docs/language/modules/develop/providers.mdx:  credentials = "${file("account.json")}"
./website/docs/language/modules/develop/providers.mdx:  credentials = "${file("account.json")}"
./website/docs/language/state/remote-state-data.mdx:  subnet_id = "${data.terraform_remote_state.vpc.subnet_id}"
./website/docs/language/state/remote-state-data.mdx:  subnet_id = "${data.terraform_remote_state.vpc.subnet_id}"
./website/docs/language/state/workspaces.mdx:  count = "${terraform.workspace == "default" ? 5 : 1}"

[nimzo6689]

@radeksimko
Thank you for the comment.
I have made the requested modifications, except for the following files:

./website/docs/language/backend/gcs.mdx:  content  = "${data.terraform_remote_state.foo.greeting}"
./website/docs/language/state/remote-state-data.mdx:  subnet_id = "${data.terraform_remote_state.vpc.subnet_id}"
./website/docs/language/state/remote-state-data.mdx:  subnet_id = "${data.terraform_remote_state.vpc.subnet_id}"

The reason these files were not modified is that they contain comments indicating they are written for Terraform <= 0.11, as shown below:

# Terraform >= 0.12
resource "aws_instance" "foo" {
  # ...
  subnet_id = data.terraform_remote_state.vpc.outputs.subnet_id
}

# Terraform <= 0.11
resource "aws_instance" "foo" {
  # ...
  subnet_id = "${data.terraform_remote_state.vpc.subnet_id}"
}

Since string interpolation became optional starting with Terraform v0.12, I decided to leave these lines unchanged.

https://github.com/hashicorp/terraform/blob/v0.12/CHANGELOG.md

First-class expressions: Prior to v0.12, expressions could be used only via string interpolation, like "${var.foo}". Expressions are now fully integrated into the language, allowing them to be used directly as argument values, like ami = var.ami.

[radeksimko]

Thanks 👍🏻

[github-actions]

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.