getmodules: support tbz2 module archives
#36081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tbz2` extension, a shorthand for `tar.bz2`, is supported for downloading and handling compressed archives in go-getter, which already treats both `tbz2` and `tar.bz2` as using the same bzip2 decompressor. This commit adds support for the `tbz2` decompressor when fetching modules from a source. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
- Grouped decompressor extensions (bz2, gzip, xz, zip). - Grouped getters (protocol-based, cloud storage, version control, file-based). Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
bschaatsbergen
commented
Nov 22, 2024
|
|
||
| // Bzip2 | ||
| "bz2": new(getter.Bzip2Decompressor), | ||
| "tbz2": new(getter.TarBzip2Decompressor), |
There was a problem hiding this comment.
For clarity, this is the tbz2 decompressor I'm adding.
Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>
rkoron007
previously approved these changes
Nov 25, 2024
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36080
Our documentation suggests that files with the
tar.bz2,tar.tbz2andtbz2extension can be fetched, unpacked and used as modules—howevertbz2is currently not supported.In go-getter there is a decompressor for tar archives compressed with bzip2 that can handle both
tar.bz2,tar.tbz2andtbz2files. See https://github.com/hashicorp/go-getter/blob/main/decompress_tbz2.go#L28-L48This PR adds
tbz2files, enabling the unpacking oftbz2module archives