Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update equivalence testing framework to resolve flaky tests #36179

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Update equivalence testing framework to resolve flaky tests #36179

merged 4 commits into from
Dec 12, 2024

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Dec 9, 2024 •
edited
Loading

I also ran the equivalence tests locally to verify the changes, and they are included in this PR.

@liamcervante liamcervante requested a review from a team as a code owner December 9, 2024 15:25
DanielMSchmidt
DanielMSchmidt previously approved these changes Dec 9, 2024
View reviewed changes
@liamcervante
Copy link
Member Author

Just holding off on this until hashicorp/terraform-equivalence-testing#32 is merged and released, as I think that'll fix this without us having to do anything manual here.

@liamcervante liamcervante requested review from DanielMSchmidt and a team and removed request for DanielMSchmidt December 12, 2024 13:15
@liamcervante liamcervante changed the title Attempt to remove flaky parts of the equivalence testing Update equivalence testing framework to resolve flaky tests Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests will be updated. Please verify the changes here.

@github-actions GitHub Actions
Copy link
Contributor

The equivalence tests will be updated. Please verify the changes here.

@liamcervante liamcervante mentioned this pull request Dec 12, 2024
Closed
@liamcervante liamcervante merged commit 3fd0cc0 into main Dec 12, 2024
7 checks passed
@liamcervante liamcervante deleted the liamcervante/equivalence-test-flakes branch December 12, 2024 14:54
@github-actions GitHub Actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SarahFrench SarahFrench SarahFrench approved these changes

@DanielMSchmidt DanielMSchmidt DanielMSchmidt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liamcervante @DanielMSchmidt @SarahFrench