Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding tags to elasticsearch #3619

Closed
wants to merge 1 commit into from
Closed

[WIP] Adding tags to elasticsearch #3619

wants to merge 1 commit into from

Conversation

JefStat
Copy link
Contributor

@JefStat JefStat commented Oct 23, 2015

First time at writing go. So I will be needing quite a bit of help to get this completed so I'm using the pull request to communicate.

Followed the setup instructions but cannot compile locally due to this error:

➜  terraform git:(elasticsearchTags) ✗ make
go generate ./...
2015/10/23 12:36:06 Missing -project and -zone and -cluster
exit status 1
src/google.golang.org/cloud/bigtable/cmd/cbt/cbt.go:368: running "go": exit status 1
make: *** [generate] Error 1

return err
}

d.Set("tags", resp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this likely won't work, as the Tags are a schema set and the results of ListTags will be a slice of []*elasticsearch.Tags. We have to do a few steps here, see ELB as a resource:

Which leads to a tagsELB.go file, which we'll need for elasticsearch as well. I can likely help there if you need, otherwise it should be pretty easy to just copy tagsELB.go

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Oct 28, 2015
@catsby
Copy link
Contributor

catsby commented Jan 7, 2016

Hey there – I'm going to go ahead and close this for now as we haven't heard back in a while. Let us know if by chance you pick it back up.

Thanks!

@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants