Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the tfstacks fmt command #36202

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Document the tfstacks fmt command #36202

merged 4 commits into from
Dec 13, 2024

Conversation

rkoron007
Copy link
Contributor

Quick PR to add the new tfstacks fmt command!

@rkoron007 rkoron007 added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Dec 11, 2024
@rkoron007 rkoron007 self-assigned this Dec 11, 2024
@rkoron007 rkoron007 requested review from a team as code owners December 11, 2024 21:43
Copy link
Contributor

The equivalence tests will be updated. Please verify the changes here.

RubenSandwich
RubenSandwich previously approved these changes Dec 11, 2024
Copy link

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the content, just the mdx and rendering. And as far as the mdx and rendering goes, it all looks good: https://terraform-hk8uqwy9n-hashicorp.vercel.app/terraform/language/stacks/reference/tfstacks-cli.

liamcervante
liamcervante previously approved these changes Dec 12, 2024
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to re-review if you add the extra info about the flags!

@rkoron007
Copy link
Contributor Author

@liamcervante Added the flags from terraform fmt and spruced up the table in that article while I was at it! Thank you again for your reviews! 🌟

@rkoron007 rkoron007 merged commit 7b2d7d0 into main Dec 13, 2024
8 checks passed
@rkoron007 rkoron007 deleted the RK/tfstacks-fmt branch December 13, 2024 18:53
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants