Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Allow cluster name, not only ARN for aws_ecs_service #3668

Merged
merged 1 commit into from
Oct 28, 2015

Conversation

radeksimko
Copy link
Member

Fixes #3361

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=EcsService' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=EcsService -timeout 90m
=== RUN   TestAccAWSEcsServiceWithARN
--- PASS: TestAccAWSEcsServiceWithARN (34.38s)
=== RUN   TestAccAWSEcsServiceWithFamilyAndRevision
--- PASS: TestAccAWSEcsServiceWithFamilyAndRevision (32.85s)
=== RUN   TestAccAWSEcsServiceWithRenamedCluster
--- PASS: TestAccAWSEcsServiceWithRenamedCluster (133.63s)
=== RUN   TestAccAWSEcsService_withIamRole
--- PASS: TestAccAWSEcsService_withIamRole (114.89s)
=== RUN   TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withEcsClusterName (37.41s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    353.186s

@catsby
Copy link
Contributor

catsby commented Oct 28, 2015

LGTM

radeksimko added a commit that referenced this pull request Oct 28, 2015
provider/aws: Allow cluster name, not only ARN for aws_ecs_service
@radeksimko radeksimko merged commit 91f4be2 into hashicorp:master Oct 28, 2015
@radeksimko radeksimko deleted the b-aws-ecs-cluster-arn branch October 28, 2015 16:28
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ecs_service tries to force a new resource on every run
2 participants