Configurable disk types for GCE #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports configuring the disk type for Google Compute Engine disk resources. Both `google_compute_disk` and `google_compute_instance` disk types are supported. Resolves hashicorp#351.
|
This LGTM. For this feature it'd be great to get acceptance tests if possible, but I'l merge as-is and add later. If you beat me to it then please PR. |
mitchellh
added a commit
that referenced
this pull request
Oct 8, 2014
…-types Configurable disk types for GCE
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports configuring the disk type for Google Compute Engine disk resources. Both
google_compute_diskandgoogle_compute_instancedisk types are supported.Resolves #351.