provider/openstack: openstack_networking_port_v2 resource #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds further work to the OpenStack port resource: * Makes relevant fields computed * Adds state change functions * Adds acceptance tests * Adds Documentation
jtopjian
added a commit
that referenced
this pull request
Nov 3, 2015
provider/openstack: openstack_networking_port_v2 resource
| region = "%s" | ||
| name = "port_1" | ||
| network_id = "${openstack_networking_network_v2.foo.id}" | ||
| admin_state_up = "true" |
There was a problem hiding this comment.
Would it make sense to also allow none-string true? I was surprised that it doesn't work with boolean value
There was a problem hiding this comment.
admin_state_up is defined as a String in the port resource, but boolean in all other network resources. Fixing this.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.