Skip to content

Conversation

@SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Oct 29, 2025

Manual backport of #37752, replaces #37836

This will unblock v1.13.X patch releases, as the prepare pipeline currently fails due to this dependency: https://github.com/hashicorp/terraform/runs/53922829576

Target Release

1.13.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Oct 29, 2025
@SarahFrench SarahFrench marked this pull request as ready for review October 29, 2025 11:01
@SarahFrench SarahFrench requested review from a team as code owners October 29, 2025 11:01
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it would be useful to run the S3 backend tests, given the anticipated impact of the change.

@SarahFrench
Copy link
Member Author

LGTM, though it would be useful to run the S3 backend tests, given the anticipated impact of the change.

I've just been preparing #37838 to allow tests to be run on this release branch - currently s3 tests on v1.13 fail due to test issues not due to the backend having any bugs.

@SarahFrench
Copy link
Member Author

I rebased this PR locally onto the v1.13 branch after merging #37838 and the tests pass as expected:

s3 % git rebase v1.13               
Successfully rebased and updated refs/heads/1.13-deps-bump.
s3 % TF_ACC=1 go test ./...     
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 324.129s

@SarahFrench SarahFrench merged commit 9790af4 into v1.13 Oct 29, 2025
18 of 19 checks passed
@SarahFrench SarahFrench deleted the 1.13-deps-bump branch October 29, 2025 12:24
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants