PSS: Refactor Plan struct to reference Backend and StateStore via pointers, update calling code
#37946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
added
the
no-changelog-needed
Contributor
|
The equivalence tests failed. Please investigate here. |
SarahFrench
force-pushed
the
pss/plan-struct-backend-via-pointer
branch
from
28593fe to
6b77cfd
Compare
…ccessing the Backend field on a Plan struct
…te a nil check in calling code.
SarahFrench
force-pushed
the
pss/plan-struct-backend-via-pointer
branch
from
6b77cfd to
37af64b
Compare
SarahFrench
commented
Nov 28, 2025
radeksimko
approved these changes
Nov 28, 2025
Member
radeksimko
left a comment
radeksimko
left a comment
There was a problem hiding this comment.
LGTM, thank you for splitting this out
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a big PR, #37248, that I'm trying to break down into multiple smaller PRs that are easier to review.
In the past a Plan would always need to describe a backend, so the Backend field was a value. Now that a Plan can describe either a Backend or a StateStore I've updated those fields to both be pointers. That makes it easier to detect which one is set or unset.
Target Release
N/A
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry