providers/openstack: add port_id to router interface #3815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another nice one 😄 I should be able to look this over in the next day or so. |
|
@jtopjian there was a minor bug with deletion, but now it's fixed |
|
@jtopjian did you have time to check it out? Would be great to stop compiling personal fork and using it :) |
|
@Fodoj I apologize - I've been tied up with a few other things, including the security group bug. I'll try to review this as soon as I can. |
omeid
pushed a commit
to omeid/terraform
that referenced
this pull request
Mar 30, 2018
…pe-doc Document additional allowed source type GITHUB_ENTERPRISE
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to create router interface either with subnet id or with port id. Thats also how it implemented in gophercloud: https://github.com/rackspace/gophercloud/blob/master/openstack/networking/v2/extensions/layer3/routers/requests.go#L173
This PR addresses this issue by making subnet id not required and adding a way to specify port id.