provider/google: Updated Read(..) behavior to handle deleted resources

[lwander]

When Terraform discovers that a resource has been deleted on a Read, it should update the statefile accordingly. This behavior was pointed out by @apparentlymart in #3742 as the standard, and with this PR all GCP resources follow this convention.

@sparkprime

[radeksimko]

Just one nitpick, otherwise LGTM - it would be probably more useful for potential debugging and reading crash logs in the future to replace the inline comment // The resource doesn't exist anymore with something like log.Printf("[WARN] Removing URL map %q because it's gone", name).

[lwander]

@radeksimko, good idea, I'll update that for all the Google resources.

[coffeepac]

This is an awesome feature. would love to see it mainline. Actually got into a bit of a discussion with a coworker because I thought it was in mainline.

[lwander]

Fixes #4539

@radeksimko, I've added the logging, does it look good to you?

[phinze]

@lwander This LGTM, merge at will once Travis passes

[radeksimko]

// The resource doesn't exist anymore that comment is I think superfluous, but I don't mind merging it as is, as soon as Travis build turns green. 👍

[coffeepac]

Woo! Thanks team!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.