AWS - Allow enabling ClassicLink on VPN creation.

[robwar]

The AWS GO SDK allows this now, so I've updated Terraform accordingly.

Solves this issue: #2985

[catsby]

Hey @robwar sorry for the silence here. I've reviewed this and think we need some things:

• Rename the attribute to enable_classic_link
• Move the enabling of classic to the update method, and call EnableVpc or DisableVpc according to the value in the configuration
• In the read method, we'll need to call DescribeVpcClassicLink to check the status of the VPC and if it has Classic enabled
• Documentation on the new attribute
• An acceptance test that confirms the value is set correctly

For acceptance tests, you can probably use the TestAccAWSVpc_tags test as an example:

• https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_vpc_test.go#L55

For documentation, look in the website folder in the root of the Terraform project, and the README will help get you started on running the site locally. From there, it's adding documentation in Markdown format

• https://github.com/hashicorp/terraform/tree/master/website

Let us know if you have other questions!

[catsby]

Actually @robwar, it looks like #3994 has all the things I'm looking for, so I'm going to go ahead and merge that. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.